[Eeglablist] Huge speedup in runica

[Delorme, Arnaud]

Thank you Curtis
I have added your comment. If anybody else want to comment on that issue, feel free to do so.

https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_sccn_eeglab_issues_310&d=DwIGaQ&c=-35OiAkTchMrZOngvJPOeA&r=kB5f6DjXkuOQpM1bq5OFA9kKiQyNm1p6x6e36h3EglE&m=E51BUKUQFM7Vf8M5utUzzYGDdmHnFsg--G0jypC3G6Y&s=eTVYglK4gK0x76ioq4iCEp23VEIfJ3UFB9KxBd4qZvE&e= 

Also, apparently the slowdown also occurs when there is no interactive GUI, so this should definitely be fixed.
Cheers,

Arno

> On Jun 17, 2021, at 2:33 PM, Curtis Bingham <cnbingham at gmail.com> wrote:
> 
> During the conference on Tuesday someone wrote: 
>  
> “Just something that I found in the runica() script: if you comment out "drawnow" on line 1047, there is a dramatic speed-up of the script. This has something to do with the GUI and nothing with ICA itself, so I think it could easily be optimized.”
> Arnaud created an issue in github for runica.m.
>  
> Replacing ‘drawnow’ with ‘drawnow limitrate’ cuts the processing time in my trials from ~400 seconds to 55-64 seconds. I’m processing 19 channel data, 10 minutes in length, no ERPs. I’m sure the gains will be even more significant with additional channels and especially with multiple data sets within a STUDY. 
>  
> The drawnow function is called in 6 different places in repeating loops. It is designed to allow gui refresh and callbacks to be executed when running within the gui.  Commenting it out removes all interactivity with Matlab or EEGLab while running an extended ICA decomposition.  
>  
> If you append ‘limitrate’ to the command, it only refreshes the gui every 20fps instead of every time the function is called. If less than 50ms have elapsed since the last call it tosses graphics updates but executes callbacks. Very good interactivity is retained, as is the ability to interrupt the ICA decomposition. 
>  
> Merely commenting out the drawnow doesn’t materially change the execution time on my data. However, as a matter of good coding practice this should be turned off altogether if not running inside a GUI. 
>  
> I recommend that, at the very least, runica.m be modified to replace ‘drawnow’ with ‘drawnow limitrate’. 
>  
> Curtis