[Eeglablist] IClabel missing function

Tue Nov 8 23:20:38 PST 2022

You need to read more carefully .... IClabels calls 'window*s*' from 
firfilt, it does not call 'window' from signal processing (the proof 
being argument ins are different)

John is right IMO

On 09/11/2022 01.16, Arnaud Delorme wrote:
> Cyril was using ICLabel without the Firfilt plugin.
>
> ICLabel should not depend on Firfilt though and the “window” function of the signal processing toolbox could be used instead.
> I have added a more informative error message, but anyone please feel free to make a pull request.
>
> Cheers,
>
> Arno
>
>> On Nov 7, 2022, at 10:38 AM, Richards, John<RICHARDS at mailbox.sc.edu>  wrote:
>>
>> I was checking a incomplete version of Matlab and EEGlab that I don’t use.
>>
>> On my functional one:
>>
>>>> which windows
>> /work/jerlab/JERLab_Analysis/MATLAB/Tools/eeglab14_1_1b/plugins/firfilt1.6.2/windows.m
>>>> which window
>> /share/apps/MATLAB/R2019b/toolbox/signal/signal/window.m
>>
>> ***********************************************
>> John E. Richards
>> Carolina Distinguished Professor
>> Department of Psychology
>> University of South Carolina
>> Columbia, SC 29208
>> Dept Phone: 803 777 2079
>> Fax: 803 777 9558
>> Email:richards-john at sc.edu<mailto:richards-john at sc.edu>
>> https://urldefense.com/v3/__https://jerlab.sc.edu__;!!Mih3wA!FWrlcjcYugmf_2IOAtRO8AIKFqL79WbX5BcfAd6NaTkWKgm82BCKMeS9MyJHhP4x6bhFEKU-YdvlhLt0v4UuSckSBcWI0A$  
>> *************************************************
>>
>> From: Richards, John
>> Sent: Sunday, November 6, 2022 4:41 AM
>> To: ‪‪Dr Cyril Pernet<wamcyril at gmail.com>; EEGLAB List<eeglablist at sccn.ucsd.edu>; Arnaud Delorme<arnodelorme at gmail.com>
>> Subject: RE: Re:[Eeglablist] IClabel missing function
>>
>> Cyril.
>>
>> You are correct, window vs windows.
>>
>> I don’t have ICLabel installed, so cannot check that code.
>>
>> John
>>
>>
>> ***********************************************
>> John E. Richards
>> Carolina Distinguished Professor
>> Department of Psychology
>> University of South Carolina
>> Columbia, SC 29208
>> Dept Phone: 803 777 2079
>> Fax: 803 777 9558
>> Email:richards-john at sc.edu<mailto:richards-john at sc.edu>
>> https://urldefense.com/v3/__https://jerlab.sc.edu__;!!Mih3wA!FWrlcjcYugmf_2IOAtRO8AIKFqL79WbX5BcfAd6NaTkWKgm82BCKMeS9MyJHhP4x6bhFEKU-YdvlhLt0v4UuSckSBcWI0A$  
>> *************************************************
>>
>> From: ‪‪Dr Cyril Pernet <wamcyril at gmail.com<mailto:wamcyril at gmail.com>>
>> Sent: Sunday, November 6, 2022 4:31 AM
>> To: Richards, John <RICHARDS at mailbox.sc.edu<mailto:RICHARDS at mailbox.sc.edu>>; EEGLAB List <eeglablist at sccn.ucsd.edu<mailto:eeglablist at sccn.ucsd.edu>>; Arnaud Delorme <arnodelorme at gmail.com<mailto:arnodelorme at gmail.com>>
>> Subject: Re:[Eeglablist] IClabel missing function
>>
>> But the function is not 'window' it is called 'windows'
>>
>>
>> Sent from my phone
>>
>>
>> -------- Original message --------
>> From: "Richards, John" <RICHARDS at mailbox.sc.edu<mailto:RICHARDS at mailbox.sc.edu>>
>> Date: Sun, 6 Nov 2022, 09.43
>> To: "Dr Cyril, Pernet" <wamcyril at gmail.com<mailto:wamcyril at gmail.com>>, EEGLAB List <eeglablist at sccn.ucsd.edu<mailto:eeglablist at sccn.ucsd.edu>>, Arnaud Delorme <arnodelorme at gmail.com<mailto:arnodelorme at gmail.com>>
>> Subject: RE: [Eeglablist] IClabel missing function
>> Signal processing toolbox needs to be installed.
>>
>> which window
>> /share/apps/MATLAB/R2019b/toolbox/signal/signal/window.m
>>
>>
>> ***********************************************
>> John E. Richards
>> Carolina Distinguished Professor
>> Department of Psychology
>> University of South Carolina
>> Columbia, SC 29208
>> Dept Phone: 803 777 2079
>> Fax: 803 777 9558
>> Email:richards-john at sc.edu<mailto:richards-john at sc.edu>
>> https://urldefense.com/v3/__https://jerlab.sc.edu__;!!Mih3wA!FWrlcjcYugmf_2IOAtRO8AIKFqL79WbX5BcfAd6NaTkWKgm82BCKMeS9MyJHhP4x6bhFEKU-YdvlhLt0v4UuSckSBcWI0A$  
>> *************************************************
>>
>> -----Original Message-----
>> From: eeglablist <eeglablist-bounces at sccn.ucsd.edu<mailto:eeglablist-bounces at sccn.ucsd.edu>> On Behalf Of Dr Cyril, Pernet
>> Sent: Saturday, November 5, 2022 11:14 AM
>> To: EEGLAB List <eeglablist at sccn.ucsd.edu<mailto:eeglablist at sccn.ucsd.edu>>; Arnaud Delorme <arnodelorme at gmail.com<mailto:arnodelorme at gmail.com>>
>> Subject: [Eeglablist] IClabel missing function
>>
>> I have upgraded to matlab 2022 recently, trying to rerun ICLabel (v1.4), i get
>>
>> Error in eeg_rpsd (line 17)
>> window = windows('hamming', n_points, 0.54)';
>>
>> i don't seem to be able to find where is that 'windows' function from.
>>
>> thx
>>
>> cyril
>>
>>
>> _______________________________________________
>> Eeglablist page:https://urldefense.com/v3/__https://nam02.safelinks.protection.outlook.com/?url=http*3A*2F*2Fsccn.ucsd.edu*2Feeglab*2Feeglabmail.html&data=05*7C01*7CRICHARDS*40mailbox.sc.edu*7Ccdf971dd83f14dc0f7f108dabfaa86c4*7C4b2a4b19d135420e8bb2b1cd238998cc*7C0*7C0*7C638033036778096114*7CUnknown*7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0*3D*7C3000*7C*7C*7C&sdata=AXlY4oMGEJlA1w4JJgMDfMxy5TTZ2Xe*2BcDrGyUsDGHU*3D&reserved=0__;JSUlJSUlJSUlJSUlJSUlJSUlJSUlJQ!!Mih3wA!FWrlcjcYugmf_2IOAtRO8AIKFqL79WbX5BcfAd6NaTkWKgm82BCKMeS9MyJHhP4x6bhFEKU-YdvlhLt0v4UuSclQAJJGhQ$  
>> To unsubscribe, send an empty email toeeglablist-unsubscribe at sccn.ucsd.edu<mailto:eeglablist-unsubscribe at sccn.ucsd.edu>
>> For digest mode, send an email with the subject "set digest mime" toeeglablist-request at sccn.ucsd.edu<mailto:eeglablist-request at sccn.ucsd.edu>
>> _______________________________________________
>> Eeglablist page:http://sccn.ucsd.edu/eeglab/eeglabmail.html
>> To unsubscribe, send an empty email toeeglablist-unsubscribe at sccn.ucsd.edu
>> For digest mode, send an email with the subject "set digest mime" toeeglablist-request at sccn.ucsd.edu
> _______________________________________________
> Eeglablist page:http://sccn.ucsd.edu/eeglab/eeglabmail.html
> To unsubscribe, send an empty email toeeglablist-unsubscribe at sccn.ucsd.edu
> For digest mode, send an email with the subject "set digest mime" toeeglablist-request at sccn.ucsd.edu

-- 
Dr Cyril Pernet, PhD, OHBM fellow, SSI fellow
Neurobiology Research Unit,
Building 8057, Blegdamsvej 9
Copenhagen University Hospital, Rigshospitalet
DK-2100 Copenhagen, Denmark

wamcyril at gmail.com
https://urldefense.com/v3/__https://cpernet.github.io/__;!!Mih3wA!Bnu6oiDd6k6hj_EWMzogjjKXkuuPLkAE3jwGlsmdm9X0_tYTNQEBjzbSn4UnR9CMLh1QO6L8YSJA5gdd1yidgA$  
https://urldefense.com/v3/__https://orcid.org/0000-0003-4010-4632__;!!Mih3wA!Bnu6oiDd6k6hj_EWMzogjjKXkuuPLkAE3jwGlsmdm9X0_tYTNQEBjzbSn4UnR9CMLh1QO6L8YSJA5gf3Rw2BSQ$  